[openlp-dev] Removing test_pylint.py and test_bzr_tags.py

Tomas Groth second at tgc.dk
Fri Oct 26 00:35:42 EDT 2018


Hi,

The test_pylint is not as old as you think and is actually responsible for
linting on Jenkins on the old setup... Also it should only run if you
target that script specifically, so typically not on local setups. If the
new CI lint solution is superior it is ok to remove it.

The test_bzr_tags I don't know, but does not seem to be that important.

/Tomas

fre. 26. okt. 2018 04.32 skrev Raoul Snyman via openlp-dev <
openlp-dev at openlp.io>:

> Hi folks,
>
> I'd like to remove tests/utils/test_pylint.py and
> tests/utils/test_bzr_tags.py. They are currently just making running
> tests and code coverage a nightmare, and haven't served a purpose in
> years.
>
> We have done linting in Jenkins for years now, so I don't think the
> linting tests are necessary anymore.
>
> Additionally, the bzr tags test was to prevent a future tag mess that we
> haven't come across since the previous tag mess which was years and
> years ago, and I don't think it is necessary any longer.
>
> Yea/Nay?
>
> --
> Raoul Snyman
> +1 (520) 490-9743
> raoul at snyman.info
> _______________________________________________
> openlp-dev mailing list
> openlp-dev at openlp.io
> https://lists.openlp.io/mailman/listinfo/openlp-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openlp.io/pipermail/openlp-dev/attachments/20181026/5259bcdb/attachment.html>


More information about the openlp-dev mailing list